Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering bigints #3010

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Add support for rendering bigints #3010

merged 1 commit into from
Feb 13, 2021

Conversation

marvinhagemeister
Copy link
Member

Fixes #3009

@github-actions
Copy link

github-actions bot commented Feb 13, 2021

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -2% - +1% (-4.38ms - +3.07ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -4% - +5% (-1.59ms - +1.71ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +1% (-7.60ms - +10.69ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -4% - +2% (-1.28ms - +0.64ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -3% - +5% (-5.21ms - +9.67ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -7% - +2% (-3.13ms - +1.13ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -3% - +4% (-0.11ms - +0.15ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master214.76ms - 220.27ms-unsure 🔍
-1% - +2%
-3.07ms - +4.38ms
preact-local214.35ms - 219.36msunsure 🔍
-2% - +1%
-4.38ms - +3.07ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.57ms - 3.58ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.58ms - 3.58msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master76.90ms - 78.71ms-unsure 🔍
-2% - +2%
-1.30ms - +1.43ms
preact-local76.72ms - 78.76msunsure 🔍
-2% - +2%
-1.43ms - +1.30ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master118.19ms - 121.68ms-unsure 🔍
-3% - +1%
-3.05ms - +1.67ms
preact-local119.04ms - 122.21msunsure 🔍
-1% - +3%
-1.67ms - +3.05ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master134.33ms - 141.39ms-unsure 🔍
-4% - +3%
-5.22ms - +3.94ms
preact-local135.59ms - 141.42msunsure 🔍
-3% - +4%
-3.94ms - +5.22ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master80.04ms - 84.99ms-unsure 🔍
-3% - +4%
-2.85ms - +3.47ms
preact-local80.25ms - 84.17msunsure 🔍
-4% - +3%
-3.47ms - +2.85ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master129.36ms - 138.59ms-unsure 🔍
-8% - +1%
-11.95ms - +1.48ms
preact-local134.34ms - 144.08msunsure 🔍
-1% - +9%
-1.48ms - +11.95ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master82.42ms - 85.70ms-unsure 🔍
-2% - +3%
-2.01ms - +2.47ms
preact-local82.31ms - 85.35msunsure 🔍
-3% - +2%
-2.47ms - +2.01ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master35.61ms - 37.65ms-unsure 🔍
-5% - +4%
-1.71ms - +1.59ms
preact-local35.40ms - 37.99msunsure 🔍
-4% - +5%
-1.59ms - +1.71ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.50ms - 3.51ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-local3.49ms - 3.50msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1782.55ms - 1795.37ms-unsure 🔍
-1% - +0%
-10.69ms - +7.60ms
preact-local1783.98ms - 1797.02msunsure 🔍
-0% - +1%
-7.60ms - +10.69ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.97ms - 25.97ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.97ms - 25.97msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master31.97ms - 33.70ms-unsure 🔍
-2% - +4%
-0.64ms - +1.28ms
preact-local32.09ms - 32.94msunsure 🔍
-4% - +2%
-1.28ms - +0.64ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.59ms - 1.59ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.59ms - 1.59msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master181.62ms - 191.69ms-unsure 🔍
-5% - +3%
-9.67ms - +5.21ms
preact-local183.41ms - 194.37msunsure 🔍
-3% - +5%
-5.21ms - +9.67ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.17ms - 6.18ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local6.17ms - 6.18msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master42.58ms - 45.86ms-unsure 🔍
-3% - +7%
-1.13ms - +3.13ms
preact-local41.86ms - 44.59msunsure 🔍
-7% - +2%
-3.13ms - +1.13ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.83ms - 4.83ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local4.83ms - 4.83msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master3.39ms - 3.59ms-unsure 🔍
-4% - +3%
-0.15ms - +0.11ms
preact-local3.43ms - 3.60msunsure 🔍
-3% - +4%
-0.11ms - +0.15ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local0.82ms - 0.82msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented Feb 13, 2021

Size Change: +30 B (0%)

Total Size: 42.3 kB

Filename Size Change
dist/preact.js 3.96 kB +8 B (0%)
dist/preact.min.js 4 kB +7 B (0%)
dist/preact.module.js 4 kB +7 B (0%)
dist/preact.umd.js 4.04 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.49 kB 0 B
compat/dist/compat.module.js 3.5 kB 0 B
compat/dist/compat.umd.js 3.54 kB 0 B
debug/dist/debug.js 2.99 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.07 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 241 B 0 B
devtools/dist/devtools.umd.js 308 B 0 B
hooks/dist/hooks.js 1.13 kB 0 B
hooks/dist/hooks.module.js 1.15 kB 0 B
hooks/dist/hooks.umd.js 1.2 kB 0 B
jsx-runtime/dist/jsxRuntime.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 335 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 405 B 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Feb 13, 2021

Coverage Status

Coverage remained the same at 99.445% when pulling 8d9354c on bigint into c123310 on master.

@marvinhagemeister marvinhagemeister merged commit dcdc32a into master Feb 13, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for bigint.
3 participants