Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is bidderSettings.alwaysUseBid deprecated? #2983

Closed
yosiweinreb opened this issue Aug 16, 2018 · 3 comments
Closed

is bidderSettings.alwaysUseBid deprecated? #2983

yosiweinreb opened this issue Aug 16, 2018 · 3 comments
Labels

Comments

@yosiweinreb
Copy link

Was trying to find any references to this condition via the code.

// `alwaysUseBid=true`. If sending all bids is enabled, add targeting for losing bids.

besides that comment, couldn't find anything (unlike the enableSendAllBids which is clearly on)

.concat(config.getConfig('enableSendAllBids') ? getBidLandscapeTargeting(adUnitCodes, bidsReceived) : []);

Thanks.

@mkendall07
Copy link
Member

It looks like it was deprecated when sendAllBids was turned on by default. @jaiminpanchal27 can you confirm?

@yosiweinreb
Copy link
Author

So also,
http://prebid.org/dev-docs/publisher-api-reference.html#alwaysusebid
Should be removed or add deprecation note on Doc.

@jaiminpanchal27
Copy link
Collaborator

@yosiweinreb Thanks for reporting this. Create docs PR here prebid/prebid.github.io#952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants