Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support URL-safe strings in scoped packages #148

Merged
merged 2 commits into from Apr 24, 2021
Merged

fix: Support URL-safe strings in scoped packages #148

merged 2 commits into from Apr 24, 2021

Conversation

Valandur
Copy link
Contributor

Fixes #147 and adds support for scoped packages with URL-safe names.

@ralphtheninja
Copy link
Member

Could you add some tests for this?

@vweevers vweevers merged commit db36c7a into prebuild:master Apr 24, 2021
Home Prebuilders Association automation moved this from Review to Done Apr 24, 2021
@vweevers
Copy link
Member

6.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Home Prebuilders Association
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prebuild install does not work with scoped packages where the scope name has a dash
3 participants
@Valandur @ralphtheninja @vweevers