Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve vulnerabilities in dependencies (npmlog>gauge>ansi-regex) #163

Closed
michaelpinnell opened this issue Nov 18, 2021 · 4 comments · Fixed by #182
Closed

Resolve vulnerabilities in dependencies (npmlog>gauge>ansi-regex) #163

michaelpinnell opened this issue Nov 18, 2021 · 4 comments · Fixed by #182
Labels
pull request welcome A pull request is welcome

Comments

@michaelpinnell
Copy link

Recently npmlog released a new version (npm/npmlog#84) resolving among other things vulnerabilities in underlying dependencies (relating to https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-3807). So I wanted to see if there was an effort to update npmlog in this package.

@vweevers
Copy link
Member

It's too soon to be dropping Node.js 14, which upgrading npmlog would require.

The CVE seems low severity in this context. I'm happy to be proven wrong, in which case I'd suggest instead replacing npmlog with something simpler.

@vweevers vweevers added the pull request welcome A pull request is welcome label Nov 18, 2021
@alitoufighi
Copy link

Can we just manually set "ansi-regex": "^5.0.1"?

@vweevers
Copy link
Member

@vweevers
Copy link
Member

@lovell @mceachen Continuing from #180: there's no benefit to npmlog anymore. We mostly have info level logs, and npm >= 7 swallows output on success, so a simple console.error(...) is really all we need here IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request welcome A pull request is welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants