Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: ensure 'npm install' script output can be captured #181

Merged
merged 1 commit into from May 30, 2022

Conversation

lovell
Copy link
Member

@lovell lovell commented May 30, 2022

Replaces the temporary logfile workaround with the use of the foreground-scripts setting, available in npm v7+.

https://docs.npmjs.com/cli/v8/using-npm/config#foreground-scripts

(This should hopefully make removing npmlog a tiny bit easier.)

Replaces temporary logfile workaround
Copy link
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@vweevers vweevers merged commit d1853cb into prebuild:master May 30, 2022
@lovell lovell deleted the replace-npm7-temp-workaround branch May 30, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants