Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing #165

Closed
max-mapper opened this issue Feb 4, 2017 · 6 comments
Closed

Signing #165

max-mapper opened this issue Feb 4, 2017 · 6 comments

Comments

@max-mapper
Copy link

In addition to #157 it'd be cool to have signing built in to prebuild, maybe using the format from https://jedisct1.github.io/minisign/

@mafintosh
Copy link
Collaborator

Using bundled prebuilds this becomes npm's problem as we don't need to download / checksum anything. npm does that for us

@max-mapper
Copy link
Author

I don't think signing is on npms roadmap. Checksumming might be, but not signing. Context node-forward/discussions#29

@mafintosh
Copy link
Collaborator

npm already does checksumming when installing. i don't think we'd gain anything by signing if npm doesn't do it, unless i'm mistaken what you mean.

@max-mapper
Copy link
Author

  • Signing meaning "prove this was published by a keyholder"
  • Checksumming meaning "prove this file was not tampered with during the download"

@mafintosh
Copy link
Collaborator

I mean: with the prebuilds bundled inside the npm tarball I don't see what we gain by signing the binaries. It's still gonna execute JS code downloaded from npm that isn't signed.

@max-mapper
Copy link
Author

good call. i guess if npm doesnt support signing we're screwed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants