Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSI: Support compressible solvers #42

Closed
MakisH opened this issue Oct 31, 2018 · 4 comments
Closed

FSI: Support compressible solvers #42

MakisH opened this issue Oct 31, 2018 · 4 comments
Assignees
Labels
enhancement Nice to have, but not a problem FSI Fluid-structure interaction modelling Physics-related issues

Comments

@MakisH
Copy link
Member

MakisH commented Oct 31, 2018

At the moment, we compute forces in FSI/Force.C (at the FSI branch for now) assuming a constant density and viscosity. In order to support compressible solvers as well, we need to abstract these in a way similar to the KappaEffective for CHT.

An open question here is how to validate the compressible FSI, as I am not aware of any literature on this at the moment. In other words, we are looking for something similar to the Turek-Hron FSI benchmark for compressible solvers.

We already had some discussion on this with @JSeuffert. Do you maybe have anything to add here?

This is relevant to #7.

@MakisH MakisH added enhancement Nice to have, but not a problem modelling Physics-related issues labels Oct 31, 2018
@JSeuffert
Copy link
Contributor

Thanks for making this an issue and I totally agree with you @MakisH .

The compressible solvers should all have a volScalarField called “thermo:mu” for the dynamic viscosity. So in my opinion the best would be to read this at the registry. Also the density should be read from the registry and not from the dictionary.
I dont know the best solution how to structure it but maybe we can do it like the heat flux in the CHT module by implementing Force_incompessible and Force_compressible?

Regarding the verification of the compatibility of the module to different solver types, we could firstly use the Hron-Turek benchmark and solve it quasi-incompressible with a compressible solver and even with the multiphase solvers.
At the moment I also do not know a specific compressible FSI benchmark, but I will do some more research.

@derekrisseeuw
Copy link
Contributor

At the moment the code in the force class is very similar to the one in the openfoam function, but only the incompressible parts from that code are extracted. I think it would be quite straightforward to implement more of these code.

See the Openfoam forces.c

@JSeuffert
Copy link
Contributor

You are right @derekrisseeuw. That could be much easier. Thanks for this information!

@MakisH
Copy link
Member Author

MakisH commented Nov 26, 2019

This is now supported on master.

@MakisH MakisH closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Nice to have, but not a problem FSI Fluid-structure interaction modelling Physics-related issues
Projects
None yet
Development

No branches or pull requests

3 participants