Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 not supported #149

Closed
ekreate opened this issue Dec 20, 2022 · 8 comments · Fixed by #150
Closed

Python 3.11 not supported #149

ekreate opened this issue Dec 20, 2022 · 8 comments · Fixed by #150
Assignees

Comments

@ekreate
Copy link

ekreate commented Dec 20, 2022

Hi, I've tired to run the "working examples" in Python3.11 and get the following error:
image
When running the same example in Python3.9, it works fine.
really cool package! thx for all the support!

@jvdd
Copy link
Member

jvdd commented Dec 20, 2022

Hi @ekreate!
Thx for pointing this out, I'll try to reproduce this behavior myself.

Some additional questions;

  • did you install plotly-resampler using pip install?
  • what version of plotly-resampler did you install? (might perhaps be different for the 2 Python envs)
  • do other imports work? (e.g., from plotly_resampler import FigureResampler)

Cheers, Jeroen

@jvdd
Copy link
Member

jvdd commented Dec 20, 2022

Just checked the pyproject.toml and noticed that we do not support Python 3.11 yet! 🤯

python = "^3.7.1,<3.11"

Guess your issue will narrow down to relaxing this.

@jvdd jvdd self-assigned this Dec 20, 2022
@jvdd jvdd mentioned this issue Dec 20, 2022
5 tasks
@ekreate
Copy link
Author

ekreate commented Dec 21, 2022

great, thx!

@jvdd
Copy link
Member

jvdd commented Dec 21, 2022

Hey @ekreate,

I created a release candidate that contains the fixes from #150

pip install plotly-resampler==0.8.4rc1

Can you install this version in Python 3.11 environment and confirm whether this issue is now resolved?

@jvdd
Copy link
Member

jvdd commented Dec 22, 2022

Created a Python 3.11 env locally and this release candidate seems to work just fine 🎉

PS: I susepect you installed v0.2.4 of plotly-resampler in your Python 3.11 env (as this version did not yet contain an upper limit of the supported Python version). However the register_plotly_resampler functionality was only introduced in v0.7, which explains why you (i) managed to install plotly-resampler in Python 3.11, and (ii) why register_plotly_resampler was not found.

image

@ekreate
Copy link
Author

ekreate commented Dec 22, 2022

Hi, I'll be able to try it only on Monday, thx for the extremely quick response.
Happy holidays! 🎅🏼🎉

@jvdd
Copy link
Member

jvdd commented Dec 22, 2022

Perfect, looking forward to hear from you!
Enjoy the holidays 🎄 🎅

@ekreate
Copy link
Author

ekreate commented Dec 26, 2022

works perfectly! thx a bunch :)

@jvdd jvdd closed this as completed in #150 Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants