Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not assume equally sampled x-data #10

Closed
jvdd opened this issue Dec 19, 2022 · 0 comments · Fixed by #11
Closed

Do not assume equally sampled x-data #10

jvdd opened this issue Dec 19, 2022 · 0 comments · Fixed by #11
Labels
enhancement New feature or request

Comments

@jvdd
Copy link
Member

jvdd commented Dec 19, 2022

The current code assumes equally sampled x-data (bin size is expressed in number of samples - assuming there are no gaps & sampling rate does not change)

To remove this assumption we should use something like np.searchsorted to determine the start- and end-indexes of the bins (this uses the x-data values to determine the bins).

I guess for empty bins, we should also perform some cleanup?

@jvdd jvdd added the enhancement New feature or request label Dec 19, 2022
@jvdd jvdd closed this as completed in #11 Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant