This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Add support for Series and DF at methods #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmke8
reviewed
Feb 26, 2020
|
I applied your changes and I think this is ready for (squash) merge. |
rpgoldman
force-pushed
the
at-methods
branch
2 times, most recently
from
f7d1e95
to
5f7bbb8
Compare
rpgoldman
changed the title
|
@thomkeh I think that this is ready for another review, and possibly merging. |
tmke8
reviewed
Mar 3, 2020
Created _AtIndexer classes for Series and DataFrame and used them to type the corresponding at() methods.
Co-Authored-By: thomkeh <7741417+thomkeh@users.noreply.github.com>
Co-Authored-By: thomkeh <7741417+thomkeh@users.noreply.github.com>
These integers are valid alternatives to 'index' and 'columns'.
I was using `dtype` as a type where I should have been using `Type[dtype]`.
Co-Authored-By: thomkeh <7741417+thomkeh@users.noreply.github.com>
Co-Authored-By: thomkeh <7741417+thomkeh@users.noreply.github.com>
Co-Authored-By: thomkeh <7741417+thomkeh@users.noreply.github.com>
Co-Authored-By: thomkeh <7741417+thomkeh@users.noreply.github.com>
|
Resolved conflicts and force-pushed. |
|
@thomkeh (squash) merge? |
|
Sorry, I was very busy with work! Looks all good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created _AtIndexer classes for Series and DataFrame and used them to type the corresponding at() methods.
Partial solution to #74.
This doesn't fully work, because it doesn't handle the possibility that a data frame will contain categorical (string) or integer data, instead of just float. I don't know how to do this.