Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RESP3: Protocol parser: Move current parsing script into separate entity #1272

Closed
Tracked by #1047
, #1271
...
vladvildanov opened this issue May 3, 2023 · 0 comments · Fixed by #1293
Closed
Tracked by #1047
, #1271
...

RESP3: Protocol parser: Move current parsing script into separate entity #1272

vladvildanov opened this issue May 3, 2023 · 0 comments · Fixed by #1293
Labels
feature

Comments

@vladvildanov
Copy link
Contributor

  1. Create new strategy for RESP2 protocol.
  2. Create strategy resolver object.
  3. Move code responsible for RESP2 parsing into RESP2 strategy and make sure that correct strategy calls depends on protocol configuration.
  4. Make sure that RESP3 parser strategy object could extend RESP2 parser strategy.
  5. Make sure that unit test passes after moving into separate strategy.
  6. Add unit test coverage for new strategy entities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved parsing functionality into separate instances vladvildanov/predis
1 participant
@vladvildanov