New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLIENT-SETINFO to support suffixes #1398

Open

chayim opened this issue Sep 13, 2023 · 1 comment

Assignees

Labels

feature

Milestone

connection-improv...

Contributor

chayim commented Sep 13, 2023

CLIENT SETINFO should be extended to support community members inserting their own suffixes, for Redis usage.

Clients should by default set-lib during connect with their name and version.
Clients should allow users to not send this
We should allow a user do send a suffix to the LIB-NAME portion - this allows us to learn about how things are used.
Our clients continue to send their version upstream for LIB-VER

Strings should have the client name, and an optional suffix. They should be formatted ClientName(). For example:

If you're NRedisStack - LIB-NAME: NRedisStack(StackExchange.Redis-v2.6.8;.NET-6.2.18) LIB-VERSION: 0.9.1
If you're a project using NRedisStack (say SemtanticKernel): LIB-NAME (NRedisStack(SemanticKernel-v0.1.7;.NET-6.2.18) LIB-VERSION: 0.9.1

Considerations:

Users should not send brackets, or braces, and we should error accordingly.
We should replace spaces a user sends with hyphens

Member

tillkruss commented Sep 13, 2023

This requires us using pipelines for the initial connection, see #1399.

tillkruss mentioned this issue

Add parameter opt out for setinfo commands #1370

Open

tillkruss added the feature label

chayim added this to the connection-improvements milestone

chayim assigned vladvildanov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment