Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical state overlays px-branding-bar #76

Closed
akshayeshenoi opened this issue Sep 1, 2017 · 1 comment
Closed

Vertical state overlays px-branding-bar #76

akshayeshenoi opened this issue Sep 1, 2017 · 1 comment

Comments

@akshayeshenoi
Copy link

Expected behavior and actual behavior:

Branding bar shouldn't be overlaid.

Steps to reproduce the problem:

    <!-- Branding -->
    <px-branding-bar></px-branding-bar>
    <!-- Nav bar -->
    <px-app-nav
      slot="app-nav"
      selected-route="{{selected}}"
      items='[[navItems]]'
      vertical>
    </px-app-nav>

Screenshots (optional, but very helpful):

image

Fix

Add top: 2rem css to px-app-nav.

@randyaskin
Copy link
Contributor

randyaskin commented Sep 1, 2017

We can't guarantee that all applications will use the px-branding-bar, or they may want to bump the branding bar to the right instead of bumping the app-nav down (which is a valid design alternative). Also note that the branding bar does not appear on small devices by design. You should handle this in your application, e.g. https://github.com/PredixDev/px-sample-app/blob/master/sass/px-sample-app.scss#L107-L112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants