Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Codegen) Code for instrumented version seems wrong #104

Closed
ahonorat opened this issue Jan 28, 2019 · 2 comments
Closed

(Codegen) Code for instrumented version seems wrong #104

ahonorat opened this issue Jan 28, 2019 · 2 comments
Labels
bug

Comments

@ahonorat
Copy link
Contributor

ahonorat commented Jan 28, 2019 •
edited

I spotted several errors in org.preesm.codegen.xtend/stdfiles/c/dump.c , function writeTime :

  • the last loop iterates over i until 0, thus accessing dumpBuffer[-1]
  • dumps are multiplied by CLOCKS_PER_CYCLE instead of being divided by it
  • the 5ms condition to trigger new executions is wrong for the opposite reason (division instead of multiplication)
  • variable changed is useless and nbNotReady can be used instead

This issue may be linked to Issue95

Fixes are easy for Linux, however I don't if it would behave the same for Windows or DSP.
@ahonorat ahonorat added the bug label Jan 28, 2019
@ahonorat
Copy link
Contributor Author

ahonorat commented Apr 5, 2019

This issue has been fixed since commit de1a83a or version 3.5.0. Now all timings are measured in nanoseconds.

@ahonorat ahonorat closed this as completed Apr 5, 2019
@antoine-morvan
Copy link
Member

Ccheck impact in #52 & #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahonorat @antoine-morvan