Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use special context keys for automatic context values #23

Closed
jlowin opened this issue Jun 30, 2018 · 1 comment
Closed

Use special context keys for automatic context values #23

jlowin opened this issue Jun 30, 2018 · 1 comment
Assignees
Labels
enhancement An improvement of an existing feature

Comments

@jlowin
Copy link
Member

jlowin commented Jun 30, 2018

(inspired by work in #18)

Currently, when a flow adds itself to a context, it does so under the flow key (in other words, it becomes available at prefect.context.flow). This has the potential to override a possibly common user-supplied context value. Instead, any automatically-set context value (including flows, as described here, and all settings used by FlowRunner and TaskRunners, like parameters) should be put under a key, perhaps __prefect__. This way they won't shadow user variables.

@jlowin
Copy link
Member Author

jlowin commented Jun 30, 2018

➤ Jeremiah Lowin commented:

After talking with @cicdw, going to change the key to __key instead of key

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant