Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"prefix" is breaking if library overwrites jupyter settings in prefix #946

Closed
2 tasks done
Lundez opened this issue Mar 10, 2024 · 9 comments · Fixed by #959
Closed
2 tasks done

"prefix" is breaking if library overwrites jupyter settings in prefix #946

Lundez opened this issue Mar 10, 2024 · 9 comments · Fixed by #959
Assignees
Labels
bug Something isn't working

Comments

@Lundez
Copy link

Lundez commented Mar 10, 2024

Checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example

❯ pixi init
❯ pixi add python solara
  × Is a directory (os error 21)

Issue description

This code installs solara. Solara sets a default value for Jupyter to enable server rendering, this is done under prefix/etc/jupyter/....

pixi sets prefix as a file with text, pointing to the .pixi folder.
I believe, as solara is installable using micromamba, that pixi does this in an incorrect way.

Expected behavior

Installation to work correctly.

@Lundez Lundez added the bug Something isn't working label Mar 10, 2024
@ruben-arts
Copy link
Contributor

Looking in to this!

@ruben-arts
Copy link
Contributor

It would be an easy fix to rename the prefix file to something else, but I think that in this case it shows that solara has an issue. As the prefix in prefix/etc/jupyter/.. seems to actually be referring to etc/jupyter "in" the "prefix" which isn't called prefix but .pixi/envs/default in this example.

We actually have the correct location for the Jupyter related files in .pixi/envs/default/etc/jupyter

Fun note This is why `prefix.dev` is called prefix because we install in prefixes.

@wolfv
Copy link
Member

wolfv commented Mar 11, 2024

We should move the prefix file to conda-meta/prefix instead, to avoid clobbering any packages.

@Lundez
Copy link
Author

Lundez commented Mar 12, 2024

I'll make a separate request for solara to fix their thing 😊👍

But it seems based on final comment there's something for you to fix too, feel free to close ticket if not!

@maartenbreddels
Copy link

Looking at widgetti/solara@6ad9bae I think i did something wrong with refactoring from flit to hatchling.
@iisakkirotko fixed this by adding the line in widgetti/solara@080894e but we should have removed the weird "prefix" = "prefix line. Too bad, I guess you people liked that line a lot 🤣

@ruben-arts
Copy link
Contributor

ruben-arts commented Mar 12, 2024

I guess you people liked that line a lot 🤣

It's a good line ;) , I chuckled that this specific line so horribly broke the pixi install

@iisakkirotko
Copy link

Hey everyone!

As @maartenbreddels said, I think removing the "prefix" = "prefix"-line should fix the issue, although I don't think I can verify this, since it seems like pixi doesn't support installing from path/github yet. Do let me know if there is a way to do this. Interesting name collision indeed :)

@ruben-arts
Copy link
Contributor

No worries we'll fix this story on the pixi side in #959.

If you really want to test it you can create a package from the solara feedstock with the local source code you have. If the paths.json file still contains the prefix/etc/jupyter path it is not fixed.

@iisakkirotko
Copy link

I just checked, and the install works with Solara 1.29.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants