Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries to rattler-build upload #687

Open
pavelzw opened this issue Mar 1, 2024 · 5 comments
Open

Add retries to rattler-build upload #687

pavelzw opened this issue Mar 1, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pavelzw
Copy link
Collaborator

pavelzw commented Mar 1, 2024

quetz-client has the options for retries because quetz is sometimes flaky and returns 504s. It would be nice if rattler-build could do something similar.

@wolfv
Copy link
Member

wolfv commented Mar 1, 2024

Good idea!

@pavelzw pavelzw added enhancement New feature or request good first issue Good for newcomers labels Mar 4, 2024
@pavelzw
Copy link
Collaborator Author

pavelzw commented Mar 13, 2024

ideally with exponential backoff with random factor. when uploading to quetz concurrently a lot of times at once, it can happen that quetz crashes

@wolfv
Copy link
Member

wolfv commented Mar 13, 2024

Oh no!

We can just install the same reqwest_middleware RetryMiddleware and IMO it should take care of everything.

@pavelzw
Copy link
Collaborator Author

pavelzw commented Mar 13, 2024

Another issue but this is quetz related:

upload retries in quetz are broken anyways because its not unlikely that you get 502 on the first attempt, but it still goes through, and then you get 409 on your second attempt

@pavelzw
Copy link
Collaborator Author

pavelzw commented Mar 13, 2024

Also, the current behavior is that when the first package upload fails, the rest will not be tried. This is bad when the first is a 409 for some reason. Then it's not possible to upload all the packages from CI through retries of the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants