Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_singularity.py doesn't use output_dir flag #28

Closed
mokca opened this issue Mar 13, 2023 · 2 comments
Closed

run_singularity.py doesn't use output_dir flag #28

mokca opened this issue Mar 13, 2023 · 2 comments

Comments

@mokca
Copy link

mokca commented Mar 13, 2023

The run_singularity.py script has an --output_dir flag but doesn't appear to use it.

The flags summary says

  --output_dir: Path to a directory that will store the results.
    (default: '/tmp')

However, output_dir is set to the contents of TMP or TMPDIR if defined, or a generated temporary directory in tmp.

if 'TMP' in os.environ:
    output_dir = os.environ['TMP']
elif 'TMPDIR' in os.environ:
    output_dir = os.environ['TMPDIR']
else:
    output_dir = tempfile.mkdtemp(dir='/tmp', prefix='alphafold-')

The contents of FLAGS.output_dir don't appear to be used at any stage.

@prehensilecode
Copy link
Owner

The variable tmp_dir is set to the value of output_dir. Then, tmp_dir is used for the bind in line 237.

@prehensilecode
Copy link
Owner

Duplicate of #31

@prehensilecode prehensilecode marked this as a duplicate of #31 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants