Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade syntax to ES modules #60

Closed
2 of 7 tasks
rootwork opened this issue Jan 22, 2022 · 4 comments
Closed
2 of 7 tasks

Upgrade syntax to ES modules #60

rootwork opened this issue Jan 22, 2022 · 4 comments
Labels
Priority: Medium Status: Abandoned No activity, considered abandoned. Status: Blocked or Postponed On hold. Type: Chore Generic maintenance tasks. Type: Dependencies Change in project dependencies. Type: Feature New functionality. Also includes back-end improvements in performance, DX and code readability. Version: Major This will cause a major bump in the version number. x-Bot: No Abandonment This will never be marked abandoned by the status bot.

Comments

@rootwork
Copy link
Member

rootwork commented Jan 22, 2022

Type of feature

  • New functionality
  • Performance
  • Code refactoring (e.g. to be simpler or easier to understand)
  • Developer Experience (DX)
  • Other (please describe below)

Describe the feature

Several dependencies are now ES-only imports, so it makes sense to upgrade Premail to use ES syntax as well.

This seems to be a pretty good guide:
https://electerious.medium.com/from-commonjs-to-es-modules-how-to-modernize-your-node-js-app-ad8cdd4fb662

Preferred solution

No response

Alternatives

No response

Related code

No response

Additional context

package.json will need to be updated with entry points; there is debate whether ESM, transpiled or both should be included in the npm package:

https://stackoverflow.com/a/52509974
https://survivejs.com/maintenance/packaging/anatomy/#entry-points

If the feature request is approved, would you be willing to submit a Pull Request?

  • Yes
  • No
@rootwork rootwork added Type: Feature New functionality. Also includes back-end improvements in performance, DX and code readability. Priority: Medium Status: Available Not currently being worked on. Take the lead! Type: Chore Generic maintenance tasks. Type: Dependencies Change in project dependencies. Version: Minor This will cause a minor bump in the version number. x-Bot: No Abandonment This will never be marked abandoned by the status bot. labels Jan 22, 2022
@rootwork rootwork changed the title feat: Upgrade syntax to ES modules Upgrade syntax to ES modules Mar 4, 2022
@rootwork
Copy link
Member Author

It looks like unless we want to run things with the --experimental-modules flag, this will require Node 14.x or above. Which means it's blocked on #56, and will be a major version bump.

@rootwork rootwork added Status: Blocked or Postponed On hold. Version: Major This will cause a major bump in the version number. and removed Version: Minor This will cause a minor bump in the version number. Status: Available Not currently being worked on. Take the lead! labels Mar 17, 2022
@rootwork rootwork removed the x-Bot: No Abandonment This will never be marked abandoned by the status bot. label Jun 22, 2022
@github-actions github-actions bot added the Status: Stale No recent activity. label Sep 21, 2022
@premail premail deleted a comment from github-actions bot Sep 23, 2022
@rootwork rootwork added x-Bot: No Abandonment This will never be marked abandoned by the status bot. and removed Status: Stale No recent activity. labels Sep 23, 2022
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it is being marked as stale.

Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍

Because this issue is marked as stale, it will be closed and locked in 10 days if no further activity occurs. If you want to prevent it from being closed, just leave a comment.

Thank you for your contributions!

@github-actions github-actions bot added Status: Stale No recent activity. and removed Status: Stale No recent activity. labels Dec 22, 2022
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it is being marked as stale.

Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍

Because this issue is marked as stale, it will be closed and locked in 10 days if no further activity occurs. If you want to prevent it from being closed, just leave a comment.

Thank you for your contributions!

@github-actions github-actions bot added the Status: Stale No recent activity. label Mar 24, 2023
@github-actions github-actions bot closed this as completed Apr 3, 2023
Copy link

github-actions bot commented Apr 2, 2024

Issue closed and locked due to lack of activity.
If you encounter this same issue, please open a new issue and refer to this closed one.

@github-actions github-actions bot added Status: Abandoned No activity, considered abandoned. and removed Status: Stale No recent activity. labels Apr 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Medium Status: Abandoned No activity, considered abandoned. Status: Blocked or Postponed On hold. Type: Chore Generic maintenance tasks. Type: Dependencies Change in project dependencies. Type: Feature New functionality. Also includes back-end improvements in performance, DX and code readability. Version: Major This will cause a major bump in the version number. x-Bot: No Abandonment This will never be marked abandoned by the status bot.
Projects
None yet
Development

No branches or pull requests

1 participant