Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make USER_AGENT parser writable #145

Closed
george-gca opened this issue Apr 2, 2024 · 3 comments · Fixed by #146
Closed

Make USER_AGENT parser writable #145

george-gca opened this issue Apr 2, 2024 · 3 comments · Fixed by #146

Comments

@george-gca
Copy link
Contributor

I am trying to fetch a css file from Google fonts, and the information it generates depends on the user agent. When accessing the file from Google Chrome it returns all fonts inside as woff2 files, but when reading the file straight with load_uri it returns all fonts as ttf files. I believe being able to set the USER_AGENT value would fix this.

@grosser
Copy link
Contributor

grosser commented Apr 2, 2024

PR welcome, sounds like a small/innocent change

@george-gca
Copy link
Contributor Author

What do you think would be the best solution for this? Create as an option in the constructor, or enable a setter?

@grosser
Copy link
Contributor

grosser commented Apr 2, 2024

lots of options in the constructer already so should be a good fit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants