Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premailer now changes the XHTML tags without changing the doctype #13

Closed
lurkerX opened this issue Nov 10, 2010 · 4 comments
Closed

Premailer now changes the XHTML tags without changing the doctype #13

lurkerX opened this issue Nov 10, 2010 · 4 comments
Labels

Comments

@lurkerX
Copy link

lurkerX commented Nov 10, 2010

First, let me say how great Premailer is and thank you. You have saved me countless hours!

I typically build my HTML email layouts with XHTML Transitional doctype and I have had good results. In the past Premailer had no problems and happily made my images paths absolute and my CSS inline. Life was good. Now it looks like premailer is getting more aggressive and is rewriting such tags as BR and IMG so they are not closed in XHTML. Now am getting lots of validation errors. I am not sure if this is a "feature" or a "bug". If a feature could this be made an option?

@dstj
Copy link

dstj commented Nov 10, 2010

This is related to the following bug report:
https://github.com/alexdunae/premailer/issues/closed#issue/10

@alexdunae
Copy link
Contributor

I've just pushed out an update to http://premailer.dialect.ca/ -- can you try processing your document again and let me know how it works?

@lurkerX
Copy link
Author

lurkerX commented Nov 11, 2010

You rock. At first pass everything works great. I will kick the tires some more and let you know if anything else crops up. I owe you a couple dozen cases of beer.

Cheers,

@alexdunae
Copy link
Contributor

All bug reports should end in beer :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants