Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove e.printStackTrace() #379

Closed
froque opened this issue Feb 15, 2023 · 0 comments · Fixed by #499
Closed

Remove e.printStackTrace() #379

froque opened this issue Feb 15, 2023 · 0 comments · Fixed by #499

Comments

@froque
Copy link
Member

froque commented Feb 15, 2023

Several tests contains e.printStackTrace() which may hide failures without failing any test.

Replace with throw new RunTimeException(e);

❯ git grep --heading printStackTrace
billy-france/src/test/java/com/premiumminds/billy/france/test/FRPersistencyAbstractTest.java
82:            e.printStackTrace();
100:            e.printStackTrace();
117:            e.printStackTrace();
billy-france/src/test/java/com/premiumminds/billy/france/test/services/documents/handler/TestFRInvoiceIssuingHandler.java
56:            e.printStackTrace();
billy-france/src/test/java/com/premiumminds/billy/france/test/services/documents/handler/TestFRInvoiceIssuingHandlerWithTicket.java
82:            e.printStackTrace();
84:            e.printStackTrace();
154:            e.printStackTrace();
....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant