Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoGetterProperty and DoSetterProperty #41

Open
prepare opened this issue Sep 26, 2017 · 1 comment
Open

DoGetterProperty and DoSetterProperty #41

prepare opened this issue Sep 26, 2017 · 1 comment

Comments

@prepare
Copy link
Owner

prepare commented Sep 26, 2017

see #40 (comment)

@dpwhittaker
Copy link

I believe this is in reference to:

One more issue I've identified. When there are more than 127 property accessors in the sytem, the native side starts looking for negative mIndexes in DoGetterProperty and DoSetterProperty. Turned out this was due to the BinaryStreamReader decoding bytes as chars instead of unsigned chars. I switched all the chars to unsigned chars and the problem went away.

The fix is literally replace the 6 lines in mini_BinaryReaderWriter.cpp that look like:
char byte0 = this->stream[start];
with:
unsigned char byte0 = this->stream[start];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants