Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inMemoryHtmlCache seems to be broken #65

Closed
lammertw opened this issue Mar 1, 2014 · 2 comments
Closed

inMemoryHtmlCache seems to be broken #65

lammertw opened this issue Mar 1, 2014 · 2 comments

Comments

@lammertw
Copy link
Contributor

lammertw commented Mar 1, 2014

I've been trying to get the inMemoryHtmlCache to work. It doesn't seem to work at all. After a little bit of debugging it does not seem to share a single cache between all workers. And even worse, it appears to create a separate cache for the beforePhantomRequest and afterPhantomRequest functions. Therefore the page being caches in afterPhantomRequest can never be read from the beforePhantomRequest function.

@thoop
Copy link
Contributor

thoop commented Mar 1, 2014

Looks like I didn't correctly update that when we switched to the multi-process version of Prerender. I'll look at fixing it soon.

Thanks for letting me know!

@thoop
Copy link
Contributor

thoop commented Apr 24, 2014

should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants