Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small issue with the target blank #4

Closed
mbiesiad opened this issue Feb 15, 2022 · 2 comments
Closed

Small issue with the target blank #4

mbiesiad opened this issue Feb 15, 2022 · 2 comments

Comments

@mbiesiad
Copy link
Contributor

mbiesiad commented Feb 15, 2022

Hi. First of all, great work!

Not a big deal, but at this moment there is:
image
and next, there is also:
image

Both of the chars are usually very close to each others on the keyboard (ie. QWERTY type). I suppose, that's the reason.

PR with solution/fixes:
#3

It is worth emphasizing that target="_blank" behaves differently than target="blank" (as at this moment), so the slightly present behavior is also corrected.

Best wishes,
Michal

@jejopl
Copy link
Contributor

jejopl commented Jun 1, 2022

Fixed by @mbiesiad - thanks! :-)

@jejopl jejopl closed this as completed Jun 1, 2022
@mbiesiad
Copy link
Contributor Author

mbiesiad commented Jun 2, 2022

My pleasure! 🎉 Best wishes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants