feat: detect running package manager #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for usepreset ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Unless a different order for the detection strategy is desired, this PR is ready for review. |
|
Neat, thanks a lot! At first glance this looks good, I'll double-check, merge and release tomorrow when I get back home |
innocenzi
approved these changes
Apr 25, 2023
|
Thank you! |
|
Thank you @innocenzi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for detecting the package manager that started the preset.
Closes #119.
How it works
The current detection strategy has been updated to take into account the
npm_config_user_agentenvironment variable that major package managers set when running.Important
npm_config_user_agentvariable is undefined, the detection falls back to the lockfile-based detection strategy.Notes
I have added tests and have added
--ignore-workspaceto commands running in tests with pnpm, to prevent updating the rootpnpm-lock.yamlfile in the repository when running tests.