Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webbook image margins don't work for inline (within paragraph) images #352

Open
ghost opened this issue Nov 6, 2018 · 2 comments
Open
Assignees
Labels
buckram This issue affects book theme components bug Something isn't working needs-reproduction

Comments

@ghost
Copy link

ghost commented Nov 6, 2018

@greatislander commented on Sep 27, 2018, 7:22 PM UTC:

This issue was moved by greatislander from pressbooks/buckram#223.

@ghost ghost added the bug Something isn't working label Nov 6, 2018
@greatislander greatislander added the buckram This issue affects book theme components label Nov 6, 2018
@mcgratay
Copy link

mcgratay commented Jan 7, 2020

Confirmed as reproducible. Any right- or left-aligned images added inline will lack a margin between the text and the image.

Screen Shot 2020-01-07 at 3 16 29 PM

Occurs with all image sizes, in all tested Buckram themes. Note that inline images cause issues in export formats too, with text unable to wrap around the image. The solution here may not be changing the CSS to accept inline images but rather changing the editor so that it's very hard to accidentally format images inline.

Example: https://imagemargins.textopress.com/chapter/chapter-1/

@SteelWagstaff
Copy link
Member

May be fixed by latest changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buckram This issue affects book theme components bug Something isn't working needs-reproduction
Projects
None yet
Development

No branches or pull requests

3 participants