Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support an IdP metadata URL with many IDPSSODescriptor nodes #4

Open
dac514 opened this issue Sep 4, 2018 · 0 comments
Open

Support an IdP metadata URL with many IDPSSODescriptor nodes #4

dac514 opened this issue Sep 4, 2018 · 0 comments
Labels
enhancement New feature or request SSO

Comments

@dac514
Copy link
Contributor

dac514 commented Sep 4, 2018

If you paste https://md.incommon.org/InCommon/InCommon-metadata.xml into the IdP metadata URL field, ie.

image

Then the plugin will auto-fill the fields using the first found IDPSSODescriptor.

InCommon-metadata.xml contains thousands of entries. The first one might not be the one we want.

\OneLogin\Saml2\IdPMetadataParser::parseRemoteXML can take a 2nd parameter: $entityId

Entity Id of the desired IdP, if no entity Id is provided and the XML metadata contains more than one IDPSSODescriptor, the first is returned.

We should fix Automatic Configuration to use this parameter, as needed.

https://github.com/pressbooks/pressbooks-shibboleth-sso/blob/5d61f5a8d1eead18bf131c233965762521aa245d/inc/class-admin.php#L124-L125
@SteelWagstaff SteelWagstaff added SSO enhancement New feature or request labels Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request SSO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dac514 @SteelWagstaff