Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid remote import in XSL file #3

Closed
gunnarmorling opened this issue Jul 22, 2015 · 7 comments
Closed

Avoid remote import in XSL file #3

gunnarmorling opened this issue Jul 22, 2015 · 7 comments

Comments

@gunnarmorling
Copy link

In https://github.com/pressgang/pressgang-tools/blob/master/pressgang-xslt-ns/src/main/resources/xslt/org/jboss/pressgang/xhtml.xsl there is a remote import to another XSL file on SourceForge. Ideally, this should be replaced with a local copy of that file to avoid issues during outages as the recent SF downtime.

@ge0ffrey
Copy link
Contributor

jdocbook-core (which is used by the maven and gradle plugin) automatically do that: they notice the url, replace it with their local copy (if the versions match!) and do not use the internet to build.
That being said, there were issues with that: but I know it works well with the latest maven plugin, the latest pressgang tools, etc. See the pressgangs-tools-example here, or the optaplanner-docs build (which inherits from kie-parent-metadata).

@gunnarmorling
Copy link
Author

gunnarmorling commented Jul 23, 2015 via email

@hferentschik
Copy link

FYI, this was part of the ORM documentation build. This uses the gradle docbook plugin - https://github.com/gradle/gradle-jdocbook which in turn seems to use version 1.1.0 of jdocbook-core - https://github.com/gradle/gradle-jdocbook/blob/master/build.gradle#L58. Would that version be obsolete? Maybe it is a question of upgrading the version used in the gradle plugin?

@ge0ffrey
Copy link
Contributor

The gradle plugin should define the jdcobook-core version, your pom only need to use the correct (=latest) gradle plugin version and presggang-* version, to make sure to have a combination that works offline.

@ge0ffrey
Copy link
Contributor

cc @psiroky

@hferentschik
Copy link

FYI - gradle/gradle-jdocbook#21

@ge0ffrey
Copy link
Contributor

Thanks, Closing the issue on this side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants