Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration form bug, needs immediate fix #239

Closed
grzegorzgit opened this issue May 11, 2021 · 7 comments
Closed

Registration form bug, needs immediate fix #239

grzegorzgit opened this issue May 11, 2021 · 7 comments

Comments

@grzegorzgit
Copy link

Hi,
I have just found out that new customers cannot register, and it's because of invalid address form.

If you fill the address form (in checkout, as a new customer), but you skip one required field, the form is submitted but come back with an error. After this submit (and new page load) the submit button is no longer active, and filling out the missing required field doesn't make the button active again.

So basically if you fill out the address form, but you forget to fill one required field, you will be stacked with that page and not able to go further.

Refreshing page sometimes helps and activate the button. My guess is that in JS validation, there is missing something that checks if the required field was filled and makes the submit button active.

Please consider fixing this immediately, it is a serious problem.

@prestarocket
Copy link
Collaborator

@grzegorzgit are you using the release zip or dev branch ?

@grzegorzgit
Copy link
Author

grzegorzgit commented May 12, 2021

The zip, from here https://github.com/prestarocket-agence/classic-rocket

It is not only in the address form but also in the registration form... how is it possible that such bug got through? Literally your theme disables registering new customers

@lmeyer1
Copy link

lmeyer1 commented May 12, 2021

I'm using develop branch, and I cannot reproduce, neither on registration nor on address form.

@grzegorzgit
Copy link
Author

Ok, I am glad that it works on dev :D but the link that people download the theme, the official version is broken. Commenting out validation in form.js fixes the problem (form.js:58).

@IJVo
Copy link

IJVo commented May 16, 2021

Dev does not work on PrestShop 1.7.7.3 and 1.7.7.4 :-( Is there anyone who can handle this? It is not possible to run a store where customers have trouble registering.

@lmeyer1
Copy link

lmeyer1 commented May 17, 2021

@IJVo

Dev does not work on PrestaShop 1.7.7.3 and 1.7.7.4

What problem do you have? With me it works, but for productcomments and blockwishlist. I'm working on fixing both. See PR #237, #238 and #241

@prestarocket
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants