Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange piece of code in AdminProductsController #102

Closed
gonandriy opened this issue Dec 18, 2012 · 1 comment
Closed

Strange piece of code in AdminProductsController #102

gonandriy opened this issue Dec 18, 2012 · 1 comment

Comments

@gonandriy
Copy link

In AdminProductsController::processDelete
you writes in comments

/*
* @since 1.5.0
* It is NOT possible to delete a product if there are currently:
* - physical stock for this product
* - supply order(s) for this product
*/

but seems still continue deleting after this check.
This could be mistake.

@vAugagneur
Copy link
Contributor

Hi,

It's work fine. First you have to enable stock management and you need to have physical quantity > 0.
If you have this 2 condition you will have this error message : "You cannot delete the product because there is physical stock left or supply orders in progress"

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants