Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move Hive legacy security config to separate class
- Loading branch information
Showing
10 changed files
with
146 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
presto-hive/src/main/java/com/facebook/presto/hive/security/LegacySecurityConfig.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Original file line | Diff line number | Diff line change |
|---|---|---|---|
| @@ -0,0 +1,77 @@ | |||
| /* | |||
| * Licensed under the Apache License, Version 2.0 (the "License"); | |||
| * you may not use this file except in compliance with the License. | |||
| * You may obtain a copy of the License at | |||
| * | |||
| * http://www.apache.org/licenses/LICENSE-2.0 | |||
| * | |||
| * Unless required by applicable law or agreed to in writing, software | |||
| * distributed under the License is distributed on an "AS IS" BASIS, | |||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| package com.facebook.presto.hive.security; | |||
|
|
|||
| import io.airlift.configuration.Config; | |||
| import io.airlift.configuration.ConfigDescription; | |||
|
|
|||
| public class LegacySecurityConfig | |||
| { | |||
| private boolean allowAddColumn; | |||
| private boolean allowDropTable; | |||
| private boolean allowRenameTable; | |||
| private boolean allowRenameColumn; | |||
|
|
|||
| public boolean getAllowAddColumn() | |||
| { | |||
| return this.allowAddColumn; | |||
| } | |||
|
|
|||
| @Config("hive.allow-add-column") | |||
| @ConfigDescription("Allow Hive connector to add column") | |||
| public LegacySecurityConfig setAllowAddColumn(boolean allowAddColumn) | |||
| { | |||
| this.allowAddColumn = allowAddColumn; | |||
| return this; | |||
| } | |||
|
|
|||
| public boolean getAllowDropTable() | |||
| { | |||
| return this.allowDropTable; | |||
| } | |||
|
|
|||
| @Config("hive.allow-drop-table") | |||
| @ConfigDescription("Allow Hive connector to drop table") | |||
| public LegacySecurityConfig setAllowDropTable(boolean allowDropTable) | |||
| { | |||
| this.allowDropTable = allowDropTable; | |||
| return this; | |||
| } | |||
|
|
|||
| public boolean getAllowRenameTable() | |||
| { | |||
| return this.allowRenameTable; | |||
| } | |||
|
|
|||
| @Config("hive.allow-rename-table") | |||
| @ConfigDescription("Allow Hive connector to rename table") | |||
| public LegacySecurityConfig setAllowRenameTable(boolean allowRenameTable) | |||
| { | |||
| this.allowRenameTable = allowRenameTable; | |||
| return this; | |||
| } | |||
|
|
|||
| public boolean getAllowRenameColumn() | |||
| { | |||
| return this.allowRenameColumn; | |||
| } | |||
|
|
|||
| @Config("hive.allow-rename-column") | |||
| @ConfigDescription("Allow Hive connector to rename column") | |||
| public LegacySecurityConfig setAllowRenameColumn(boolean allowRenameColumn) | |||
| { | |||
| this.allowRenameColumn = allowRenameColumn; | |||
| return this; | |||
| } | |||
| } | |||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
presto-hive/src/test/java/com/facebook/presto/hive/security/TestLegacySecurityConfig.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Original file line | Diff line number | Diff line change |
|---|---|---|---|
| @@ -0,0 +1,55 @@ | |||
| /* | |||
| * Licensed under the Apache License, Version 2.0 (the "License"); | |||
| * you may not use this file except in compliance with the License. | |||
| * You may obtain a copy of the License at | |||
| * | |||
| * http://www.apache.org/licenses/LICENSE-2.0 | |||
| * | |||
| * Unless required by applicable law or agreed to in writing, software | |||
| * distributed under the License is distributed on an "AS IS" BASIS, | |||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| package com.facebook.presto.hive.security; | |||
|
|
|||
| import com.google.common.collect.ImmutableMap; | |||
| import org.testng.annotations.Test; | |||
|
|
|||
| import java.util.Map; | |||
|
|
|||
| import static io.airlift.configuration.testing.ConfigAssertions.assertFullMapping; | |||
| import static io.airlift.configuration.testing.ConfigAssertions.assertRecordedDefaults; | |||
| import static io.airlift.configuration.testing.ConfigAssertions.recordDefaults; | |||
|
|
|||
| public class TestLegacySecurityConfig | |||
| { | |||
| @Test | |||
| public void testDefaults() | |||
| { | |||
| assertRecordedDefaults(recordDefaults(LegacySecurityConfig.class) | |||
| .setAllowAddColumn(false) | |||
| .setAllowDropTable(false) | |||
| .setAllowRenameTable(false) | |||
| .setAllowRenameColumn(false)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testExplicitPropertyMappings() | |||
| { | |||
| Map<String, String> properties = new ImmutableMap.Builder<String, String>() | |||
| .put("hive.allow-add-column", "true") | |||
| .put("hive.allow-drop-table", "true") | |||
| .put("hive.allow-rename-table", "true") | |||
| .put("hive.allow-rename-column", "true") | |||
| .build(); | |||
|
|
|||
| LegacySecurityConfig expected = new LegacySecurityConfig() | |||
| .setAllowAddColumn(true) | |||
| .setAllowDropTable(true) | |||
| .setAllowRenameTable(true) | |||
| .setAllowRenameColumn(true); | |||
|
|
|||
| assertFullMapping(properties, expected); | |||
| } | |||
| } | |||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters