Skip to content

Commit

Permalink
Rename field in CompactionSet
Browse files Browse the repository at this point in the history
  • Loading branch information
nileema committed Jun 29, 2016
1 parent 6295431 commit ebd7bf4
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
Expand Up @@ -24,22 +24,22 @@
public class CompactionSet public class CompactionSet
{ {
private final long tableId; private final long tableId;
private final Set<ShardMetadata> shardsToCompact; private final Set<ShardMetadata> shards;


public CompactionSet(long tableId, Set<ShardMetadata> shardsToCompact) public CompactionSet(long tableId, Set<ShardMetadata> shards)
{ {
this.tableId = tableId; this.tableId = tableId;
this.shardsToCompact = requireNonNull(shardsToCompact, "shardsToCompact is null"); this.shards = requireNonNull(shards, "shards is null");
} }


public long getTableId() public long getTableId()
{ {
return tableId; return tableId;
} }


public Set<ShardMetadata> getShardsToCompact() public Set<ShardMetadata> getShards()
{ {
return shardsToCompact; return shards;
} }


@Override @Override
Expand All @@ -53,21 +53,21 @@ public boolean equals(Object o)
} }
CompactionSet that = (CompactionSet) o; CompactionSet that = (CompactionSet) o;
return Objects.equals(tableId, that.tableId) && return Objects.equals(tableId, that.tableId) &&
Objects.equals(shardsToCompact, that.shardsToCompact); Objects.equals(shards, that.shards);
} }


@Override @Override
public int hashCode() public int hashCode()
{ {
return Objects.hash(tableId, shardsToCompact); return Objects.hash(tableId, shards);
} }


@Override @Override
public String toString() public String toString()
{ {
return toStringHelper(this) return toStringHelper(this)
.add("tableId", tableId) .add("tableId", tableId)
.add("shardsToCompact", shardsToCompact) .add("shards", shards)
.toString(); .toString();
} }
} }
Expand Up @@ -336,12 +336,12 @@ Set<ShardMetadata> filterShardsWithTemporalMetadata(Iterable<ShardMetadata> allS
private void addToCompactionQueue(CompactionSetCreator compactionSetCreator, long tableId, Set<ShardMetadata> shardsToCompact) private void addToCompactionQueue(CompactionSetCreator compactionSetCreator, long tableId, Set<ShardMetadata> shardsToCompact)
{ {
for (CompactionSet compactionSet : compactionSetCreator.createCompactionSets(tableId, shardsToCompact)) { for (CompactionSet compactionSet : compactionSetCreator.createCompactionSets(tableId, shardsToCompact)) {
if (compactionSet.getShardsToCompact().size() <= 1) { if (compactionSet.getShards().size() <= 1) {
// throw it away because there is no work to be done // throw it away because there is no work to be done
continue; continue;
} }


compactionSet.getShardsToCompact().stream() compactionSet.getShards().stream()
.map(ShardMetadata::getShardUuid) .map(ShardMetadata::getShardUuid)
.forEach(shardsInProgress::add); .forEach(shardsInProgress::add);


Expand Down Expand Up @@ -401,7 +401,7 @@ public CompactionJob(CompactionSet compactionSet)
@Override @Override
public void run() public void run()
{ {
Set<ShardMetadata> shards = compactionSet.getShardsToCompact(); Set<ShardMetadata> shards = compactionSet.getShards();
OptionalInt bucketNumber = shards.iterator().next().getBucketNumber(); OptionalInt bucketNumber = shards.iterator().next().getBucketNumber();
for (ShardMetadata shard : shards) { for (ShardMetadata shard : shards) {
verify(bucketNumber.equals(shard.getBucketNumber()), "mismatched bucket numbers"); verify(bucketNumber.equals(shard.getBucketNumber()), "mismatched bucket numbers");
Expand Down
Expand Up @@ -52,7 +52,7 @@ public void testNonTemporalCompactionSetSimple()


Set<CompactionSet> compactionSets = compactionSetCreator.createCompactionSets(1L, inputShards); Set<CompactionSet> compactionSets = compactionSetCreator.createCompactionSets(1L, inputShards);
assertEquals(compactionSets.size(), 1); assertEquals(compactionSets.size(), 1);
assertEquals(getOnlyElement(compactionSets).getShardsToCompact(), inputShards); assertEquals(getOnlyElement(compactionSets).getShards(), inputShards);
} }


@Test @Test
Expand Down

0 comments on commit ebd7bf4

Please sign in to comment.