Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimestampWithTimezone doesnt take into account Timezone to calculate hash #17274

Open
kgpai opened this issue Feb 9, 2022 · 2 comments
Open

Comments

@kgpai
Copy link
Contributor

kgpai commented Feb 9, 2022

Currently TimestampWithTimezone doesnt take into account timezone : https://github.com/prestodb/presto/blob/master/presto-common/src/main/java/com/facebook/presto/common/type/TimestampWithTimeZoneType.java#L53 , and

public static long unpackMillisUtc(long dateTimeWithTimeZone)
.
This might give similar results for different timezones.

@mbasmanova
Copy link
Contributor

CC: @tdcmeehan @highker @mayankgarg1990 Tim, James, Mayank, are you aware of this limitation? Would it make sense to fix it?

@mbasmanova
Copy link
Contributor

The impact of this is that checksum over timestamp with time zone column doesn't account for timezone part, hence, produces same results for two columns that differ only in time zones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants