Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Naming convention clarification #18721

Open
Mionsz opened this issue Nov 23, 2022 · 11 comments
Open

[native] Naming convention clarification #18721

Mionsz opened this issue Nov 23, 2022 · 11 comments
Labels
docs prestissimo Presto Native Execution

Comments

@Mionsz
Copy link
Contributor

Mionsz commented Nov 23, 2022

I am not sure if the valid and 'should use' name for presto-native-execution was declared. This makes some people confused and not sure if or not the listed bellow are same product:

  • Prestissimo
  • PrestoCpp
  • presto-native-execution
  • Presto native server

Could we have this clarified and replaced in the documentation or can we make a vocabulary that will clarify this?
@majetideepak

@rohanpednekar
Copy link
Contributor

@psbell-meta Could you please take this further?

@mbasmanova
Copy link
Contributor

@spershin
Copy link
Contributor

@Mionsz
Is the issue only about references in the docs or something else?

Essentially they are all the same, although the semantics might slightly change, like "Presto native server" - what does that even mean. :)
Historically, through the years of development (about 2 now) the names were brought in by different people and adopted with a different degree.

These days I try to use Presto Native and nothing else.
The folder "presto-native-execution" will likely stay as is or we can rename it if that's a good practice.
Docs can be modified, but we need to some to a consensus as to what name is the 'one to rule them all'. :)

@Mionsz
Copy link
Contributor Author

Mionsz commented Dec 14, 2022

@spershin The purpose of my question is more to clarify the naming convention - as I had an occasion to see it can confuse new users - and also it was a kind of management open question to ask what should be used like in internal documentation etc. Btw. having documentation refactored would also be a nice-to-do.

Nevertheless a simple vocabulary in documentation should be created additionally to clarify what is the proper name and how people use to call this query engine. I am not sure but this can have an impact on google search ranges and project visibility - it easier to find product if the name is clarified :).

Btw If there is some kind of consensus I can do documentation refactoring.

@spershin
Copy link
Contributor

@Mionsz

Btw If there is some kind of consensus I can do documentation refactoring.

That is probably the biggest issue.
Everyone is working on it, but no one really thinks that one unified name is important enough to get it sorted out or takes initiative to actually do something about it.

I would go as far here as to suggest to use "Presto Native", unless some in context it does not fit. :)

@Mionsz
Copy link
Contributor Author

Mionsz commented Dec 16, 2022

@mbasmanova @spershin Could you rise this issue or discuss it on corporate/team level and give a kind of permanent answer or is the "Presto Native" the one? I ask as I do feel "Presto Native" is not a catchy name at all, "Prestissimo" is lots better and will probably give more consistent search results than two words name and this implicates far greater 'ranges'.

@Mionsz
Copy link
Contributor Author

Mionsz commented Dec 16, 2022

Then we could write: "Prestissimo is a Presto Worker native execution query engine written using low-level programming languages like C++ and overcoming all of JAVA performance bottlenecks by utilizing CPU vector operations instructions sets..."

@mbasmanova
Copy link
Contributor

@Mionsz I like the description you proposed above and agree that Prestissimo is a better name than Presto Native. I'd like to wait for @majetideepak Deepak to come back (after the holidays) to bring this up for discussion and make a decision.

CC: @aditi-pandit

@majetideepak
Copy link
Collaborator

I concur with @mbasmanova and @Mionsz. We should use Prestissimo as the main name. Just like Databricks calls their stack Photon.
@Mionsz do you still have the bandwidth to implement this name change?

@Mionsz
Copy link
Contributor Author

Mionsz commented Jan 5, 2023

@majetideepak Yes I can handle this but probably not faster than in 2 weeks from now .

@majetideepak
Copy link
Collaborator

majetideepak commented Jan 6, 2023

@Mionsz that works! I will be happy to help review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs prestissimo Presto Native Execution
Projects
Status: 📋 Prioritized Backlog
Development

No branches or pull requests

7 participants