Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HiveColumnHandle checkArgument message is incorrect #22457

Closed
elharo opened this issue Apr 9, 2024 · 2 comments
Closed

HiveColumnHandle checkArgument message is incorrect #22457

elharo opened this issue Apr 9, 2024 · 2 comments

Comments

@elharo
Copy link
Contributor

elharo commented Apr 9, 2024

        checkArgument(hiveColumnIndex >= 0 || columnType == PARTITION_KEY || columnType == SYNTHESIZED || columnType == AGGREGATED, format("hiveColumnIndex:%d is negative, columnType:%s", hiveColumnIndex, columnType.toString()));

This condition can fail (correctly) when the hiveColumnIndex is not negative. Split this into multiple checks with different and correct error messages.

The fix requires a test, and that test should be written and fail before the fix is written.

@TishyaaChaudhry
Copy link
Contributor

I would like to work on this. Thanks

@elharo
Copy link
Contributor Author

elharo commented Apr 9, 2024

NVM, this check is corrct

@elharo elharo closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants