You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AbstractTestIntegrationSmokeTest is an ugly and confusing name. is it testing the integration smoke test? Or is it a test for the AbstractTestIntegrationSmoke class? And in general using the word "Abstract" in a class name is the sort of pointless verbosity that gives Java a bad name. Whether a class is abstract or not is an implementation detail that can change over time, not part of the semantic type.
IntegrationSmokeTest is perhaps better, though I'm tempted to go further with something like
ConnectorSmokeTest or ConnectorIntegrationTest
since this is really specifically for connectors, not other parts of the Presto system. And now that I think about it, ConnectorIntegrationTest is the right name. Integration tests and smoke test aren't the same thing. This is not a smoke test, which is generally understood to be a minimal test that turns the machine on and sees if smoke comes out. This is testing far more than that.
The text was updated successfully, but these errors were encountered:
AbstractTestIntegrationSmokeTest is an ugly and confusing name. is it testing the integration smoke test? Or is it a test for the AbstractTestIntegrationSmoke class? And in general using the word "Abstract" in a class name is the sort of pointless verbosity that gives Java a bad name. Whether a class is abstract or not is an implementation detail that can change over time, not part of the semantic type.
IntegrationSmokeTest is perhaps better, though I'm tempted to go further with something like
ConnectorSmokeTest or ConnectorIntegrationTest
since this is really specifically for connectors, not other parts of the Presto system. And now that I think about it, ConnectorIntegrationTest is the right name. Integration tests and smoke test aren't the same thing. This is not a smoke test, which is generally understood to be a minimal test that turns the machine on and sees if smoke comes out. This is testing far more than that.
The text was updated successfully, but these errors were encountered: