Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AbstractTestIntegrationSmokeTest --> ConnectorIntegrationTest #22952

Open
elharo opened this issue Jun 7, 2024 · 0 comments
Open

Rename AbstractTestIntegrationSmokeTest --> ConnectorIntegrationTest #22952

elharo opened this issue Jun 7, 2024 · 0 comments
Labels

Comments

@elharo
Copy link
Contributor

elharo commented Jun 7, 2024

AbstractTestIntegrationSmokeTest is an ugly and confusing name. is it testing the integration smoke test? Or is it a test for the AbstractTestIntegrationSmoke class? And in general using the word "Abstract" in a class name is the sort of pointless verbosity that gives Java a bad name. Whether a class is abstract or not is an implementation detail that can change over time, not part of the semantic type.

IntegrationSmokeTest is perhaps better, though I'm tempted to go further with something like

ConnectorSmokeTest or ConnectorIntegrationTest

since this is really specifically for connectors, not other parts of the Presto system. And now that I think about it, ConnectorIntegrationTest is the right name. Integration tests and smoke test aren't the same thing. This is not a smoke test, which is generally understood to be a minimal test that turns the machine on and sees if smoke comes out. This is testing far more than that.

@elharo elharo added the cleanup label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant