Support more comprehensive schema evolution on hudi (cow table) #18557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenshengli
requested review from
vinothchandar,
7c00 and
a team
as code owners
|
|
5 tasks
|
Hi @pratyakshsharma, can you help review this? Thanks! |
pratyakshsharma
requested changes
Dec 22, 2022
There was a problem hiding this comment.
@shenshengli Thank you for adding this missing piece. Can we add a test case to depict the fix that this PR does?
| } | ||
| List<String> requiredColumns = regularColumns.stream().map(hch -> hch.getName()).collect(toList()); | ||
| if (internalSchemaOption.isPresent()) { | ||
| // reading hoodie schema evolution table |
There was a problem hiding this comment.
nit: can change the comment to perform schema evolution on hoodie table.
|
@shenshengli Thanks for your contributions, do you think we can address the feedback, we can target this feature for next release. |
|
@shenshengli Gentle ping :) |
|
@shenshengli Friendly ping. You have a change request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: apache/hudi#6989
Fix the missing scenario in the link above