Fix failure when selecting a constant and all fields from row #10321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Dec 16, 2021
Comment on lines
321
to
322
| // Do not rewrite subscript index into symbol. Index is required to be a literal. | ||
| return coerceIfNecessary(node, new SubscriptExpression(rewrittenBase, node.getIndex())); |
There was a problem hiding this comment.
Subscript must be literal for Row type, but subscript can be used with arrays and maps too.
In a query `SELECT 1, ROW(2, 3).*`, on the planning phase the expression `Row(2, 3).*` is unfolded into subscript expressions: `ROW(2, 3)[1]` and `ROW(2, 3)[2]`. Because the query also contains the literal `1`, the subscript index in `ROW(2, 3)[1]` was rewritten into a symbol by the `TranslationMap`. The resulting expression was `ROW(2, 3)[s]`, which was incorrect, since the row subscript is required to be a constant. This change modifies the `TranslationMap`s rewrite method so that the subscript index is not rewritten.
kasiafi
force-pushed
the
298SelectAllFromRow
branch
from
c6e7f32
to
9c37eda
Compare
findepi
approved these changes
Dec 16, 2021
martint
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10298
In a query
SELECT 1, ROW(2, 3).*,on the planning phase the expression
Row(2, 3).*is unfoldedinto subscript expressions:
ROW(2, 3)[1]andROW(2, 3)[2].Because the query also contains the literal
1, the subscriptindex in
ROW(2, 3)[1]was rewritten into a symbol by theTranslationMap. The resulting expression wasROW(2, 3)[s],which was incorrect, since the row subscript is required to be
a constant.
This change modifies the
TranslationMaps rewrite methodso that the subscript index is not rewritten.