Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block creating long table names in JDBC and MongoDB connectors #12892

Merged
merged 1 commit into from Jul 4, 2022
Merged

Block creating long table names in JDBC and MongoDB connectors #12892

merged 1 commit into from Jul 4, 2022

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jun 17, 2022 •
edited

Description

Relates to #12882

Documentation

(x) No documentation is needed.

Release notes

(x) Release notes entries required with the following suggested text:

# PostgreSQL
* Prevent creating a new table which the table name is longer than the max length. 
  Previously, the name was silently truncated to the max length (63 characters by default). ({issue}`12892`)

# MongoDB
* Create a collection explicitly when creating a new table. 
  Previously, it was created when the data is written for the first time. ({issue}`12892`)

@cla-bot cla-bot bot added the cla-signed label Jun 17, 2022
@ebyhr ebyhr force-pushed the ebi/long-identifier branch 2 times, most recently from 0b7429b to 6853f97 Compare June 20, 2022 11:47
findepi
findepi reviewed Jun 20, 2022
View reviewed changes
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/BaseJdbcClient.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Outdated Show resolved Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeMinioConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java Show resolved Hide resolved
plugin/trino-phoenix5/src/main/java/io/trino/plugin/phoenix5/PhoenixClient.java Outdated Show resolved Hide resolved
plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/TestPhoenixConnectorTest.java Show resolved Hide resolved
@ebyhr ebyhr force-pushed the ebi/long-identifier branch 3 times, most recently from 87026c7 to e61bfd7 Compare June 23, 2022 01:57
@ebyhr
Copy link
Member Author

ebyhr commented Jun 23, 2022 •
edited

CI failure seems related to #11344

@ebyhr ebyhr marked this pull request as ready for review June 23, 2022 05:19
findepi
findepi approved these changes Jun 24, 2022
View reviewed changes
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Outdated Show resolved Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java Show resolved Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/BaseClickHouseConnectorTest.java Show resolved Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java Show resolved Hide resolved
...o-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseLatestConnectorTest.java Show resolved Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/AbstractKuduConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoConnectorTest.java Outdated Show resolved Hide resolved
plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/TestPhoenixConnectorTest.java Show resolved Hide resolved
plugin/trino-phoenix5/src/test/java/io/trino/plugin/phoenix5/TestPhoenixConnectorTest.java Outdated Show resolved Hide resolved
@ebyhr ebyhr mentioned this pull request Jul 4, 2022
Closed
@ebyhr
Block creating long table names in JDBC and MongoDB connectors
d54a5fb 
Previously, PostgreSQL connector silently truncated
table names to 63 characters.
Let MongoDB creates a collection explicitly because
implicit creation doesn't happen in case of long identifiers.
@ebyhr ebyhr merged commit 5e9f5ac into trinodb:master Jul 4, 2022
@ebyhr ebyhr deleted the ebi/long-identifier branch July 4, 2022 08:38
@ebyhr ebyhr mentioned this pull request Jul 4, 2022
Closed
@github-actions github-actions bot added this to the 389 milestone Jul 4, 2022
@colebow colebow mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
389
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ebyhr @findepi