Fix aggregation memory revoke when operator is finishing #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
force-pushed
the
ks/hash_agg_recok
branch
from
27089f4
to
4afc33d
Compare
findepi
reviewed
Feb 6, 2019
...src/main/java/io/prestosql/operator/aggregation/builder/SpillableHashAggregationBuilder.java
Show resolved
Hide resolved
presto-main/src/test/java/io/prestosql/operator/TestHashAggregationOperator.java
Outdated
Show resolved
Hide resolved
| .addSequencePage(10, 100, 0, 300, 0, 500) | ||
| .addSequencePage(numberOfRows, 100, 0, 100000, 0, 500) | ||
| .addSequencePage(numberOfRows, 100, 0, 200000, 0, 500) | ||
| .addSequencePage(numberOfRows, 100, 0, 300000, 0, 500) |
presto-main/src/test/java/io/prestosql/operator/TestHashAggregationOperator.java
Show resolved
Hide resolved
|
|
||
| MaterializedResult expected = expectedBuilder.build(); | ||
| MaterializedResult actual = toMaterializedResult(driverContext.getSession(), expected.getTypes(), pages); | ||
| assertEqualsIgnoreOrder(actual.getMaterializedRows(), expected.getMaterializedRows()); |
There was a problem hiding this comment.
I don't get it. Previously the code was calling assertOperatorEqualsIgnoreOrder
Now it's more verbose, including manually calling toPages, dropping hash channels, converting to MaterializedResult.
i assume this is assertOperatorEqualsIgnoreOrder inlined, but what's the actual difference?
Is this really related to increasing the data set, as Produce more than single page in testHashAggregation commit message says?
| // have a proper way to atomically convert memory reservations | ||
| localRevocableMemoryContext.setBytes(currentRevocableBytes); | ||
| // spill since revocable memory could not be converted to user memory immediately | ||
| getFutureValue(spillToDisk()); |
There was a problem hiding this comment.
This can take time.
Can we spill asynchronously?
spillToDisk();
return WorkProcessor.empty();
(then we need to updateMemory(); on next call..)
There was a problem hiding this comment.
Added todo since this requires bigger operator refactor
...src/main/java/io/prestosql/operator/aggregation/builder/SpillableHashAggregationBuilder.java
Show resolved
Hide resolved
...src/main/java/io/prestosql/operator/aggregation/builder/SpillableHashAggregationBuilder.java
Show resolved
Hide resolved
...src/main/java/io/prestosql/operator/aggregation/builder/SpillableHashAggregationBuilder.java
Show resolved
Hide resolved
...src/main/java/io/prestosql/operator/aggregation/builder/SpillableHashAggregationBuilder.java
Show resolved
Hide resolved
sopel39
force-pushed
the
ks/hash_agg_recok
branch
from
4afc33d
to
fdc38d6
Compare
|
ac |
sopel39
force-pushed
the
ks/hash_agg_recok
branch
from
fdc38d6
to
f2f743f
Compare
findepi
approved these changes
Feb 6, 2019
presto-main/src/test/java/io/prestosql/operator/TestHashAggregationOperator.java
Show resolved
Hide resolved
sopel39
force-pushed
the
ks/hash_agg_recok
branch
from
f2f743f
to
f7f1701
Compare
rice668
pushed a commit
to rice668/trino
that referenced
this pull request
Jan 31, 2023
…titions to table scan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.