Add support for Glue endpoint URL #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested manually, but it requires -Dcom.amazonaws.sdk.disableCertChecking=true, due to misalignment between cert name (glue..amazonaws.com) and actual hostname used in endpoint. |
ppalucha
force-pushed
the
add-glue-endpoint
branch
from
0e04777
to
ec55e21
Compare
Fixed by providing SSL Factory with NoopHostnameVerifier. |
|
Please reabase instead of merge commit |
sopel39
approved these changes
Mar 27, 2020
presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
ppalucha
force-pushed
the
add-glue-endpoint
branch
from
ec55e21
to
8b68280
Compare
ppalucha
force-pushed
the
add-glue-endpoint
branch
from
8b68280
to
45787a9
Compare
electrum
requested changes
Mar 27, 2020
presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
ppalucha
force-pushed
the
add-glue-endpoint
branch
from
45787a9
to
7c6c7bf
Compare
ppalucha
force-pushed
the
add-glue-endpoint
branch
from
7c6c7bf
to
aef53ff
Compare
sopel39
approved these changes
Apr 1, 2020
electrum
approved these changes
Apr 1, 2020
aweisberg
pushed a commit
to v-jizhang/presto
that referenced
this pull request
May 12, 2021
Cherry pick of trinodb/trino#3239 Co-authored-by: Pawel Palucha <pawel.palucha@starburstdata.com> Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
arhimondr
pushed a commit
to prestodb/presto
that referenced
this pull request
May 13, 2021
Cherry pick of trinodb/trino#3239 Co-authored-by: Pawel Palucha <pawel.palucha@starburstdata.com> Co-authored-by: Ashhar Hasan <hashhar_dev@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.