Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spill check #3407

Merged
merged 2 commits into from Apr 10, 2020
Merged

Remove spill check #3407

merged 2 commits into from Apr 10, 2020

Conversation

sopel39
Copy link
Member

@sopel39 sopel39 commented Apr 10, 2020

Supersedes: #3393

@sopel39
Fix formatting
9ac4a08
@sopel39
Remove problematic spill checks
65a707f 
Coordinators do not require spill paths
to be setup. Therefore spill check is problematic
as it doesn't distinguish between coordinator and workers.
@sopel39 sopel39 requested a review from findepi April 10, 2020 11:07
@cla-bot cla-bot bot added the cla-signed label Apr 10, 2020
@sopel39 sopel39 mentioned this pull request Apr 10, 2020
Closed
@sopel39 sopel39 merged commit 3f81c82 into trinodb:master Apr 10, 2020
@sopel39 sopel39 deleted the ks/remove_spill_check branch April 10, 2020 12:21
@sopel39 sopel39 mentioned this pull request Apr 10, 2020
Closed
8 tasks
@electrum electrum added this to the 333 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
333
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sopel39 @findepi @electrum