Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CREATE TABLE in Cassandra #3478

Merged
merged 2 commits into from Apr 21, 2020
Merged

Add support for CREATE TABLE in Cassandra #3478

merged 2 commits into from Apr 21, 2020

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Apr 19, 2020

No description provided.

@cla-bot cla-bot bot added the cla-signed label Apr 19, 2020
@ebyhr ebyhr changed the title Cassandra ct Add support for CREATE TABLE in Cassandra Apr 19, 2020
@ebyhr ebyhr added the WIP label Apr 19, 2020
@ebyhr ebyhr removed the WIP label Apr 19, 2020
@findepi findepi mentioned this pull request Apr 20, 2020
Merged
@findepi
Copy link
Member

findepi commented Apr 20, 2020

@ebyhr this one too -- https://github.com/prestosql/presto/blob/0c13d169dcf189d4a913187de6e33c212df92bfa/presto-cassandra/src/test/java/io/prestosql/plugin/cassandra/TestCassandraDistributedQueries.java#L163-L167

@ebyhr
Copy link
Member Author

ebyhr commented Apr 20, 2020

Unfortunately, we need to modify base testDataMappingSmokeTest due to id column name conflict. I only updated the TestCassandraDistributedQueries's comment in this PR.

@findepi
Copy link
Member

findepi commented Apr 20, 2020

@ebyhr if id is reserved in Cassandra, then sure, we can pick something else. Maybe key?
I went ahead and merged #3463 so please rebase. I think there is id there as well.

@ebyhr
Extract CREATE TABLE logic in Cassandra
2e4d499 
Additionally, remove invalid comment.
@ebyhr
Add support for CREATE TABLE in Cassandra
f4921b9 
Additionally, enable related tests in TestCassandraDistributedQueries.
@ebyhr
Copy link
Member Author

ebyhr commented Apr 21, 2020

@findepi Rebased and confirmed key is fine as Cassandra column name. I'll look into the details so that we can enable it in the connector.

@ebyhr ebyhr merged commit c54f611 into trinodb:master Apr 21, 2020
@ebyhr ebyhr deleted the cassandra-ct branch April 21, 2020 12:22
@ebyhr ebyhr mentioned this pull request Apr 21, 2020
Closed
8 tasks
@electrum electrum added this to the 333 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findepi findepi findepi approved these changes

@Praveen2112 Praveen2112 Praveen2112 approved these changes

@kokosing kokosing Awaiting requested review from kokosing

Assignees
No one assigned
Labels
cla-signed
Milestone
333
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ebyhr @findepi @Praveen2112 @electrum