Improve handing of insecure authentication over HTTP and HTTPS #4199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
insecure-authentication
branch
from
82507b3
to
73b4fc3
Compare
|
Typo in commit message (missing
|
Make insecure authentication explicit
Add option to disable insecure authentication over HTTP. This is automatically enabled when HTTPS authentication is enabled.
dain
force-pushed
the
insecure-authentication
branch
from
73b4fc3
to
49b1360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless configured for authentication, Presto allow user to connect with any username. In this PR, I make this mode explicit by introducing an "insecure" authenticator. This authenticator retains the existing behavior, any username is allowed, but no password can be sent. The default authenticator type is set to insecure so it is clear in the startup message that authentication is not secured.
In addition, the when secure authentication is configured, insecure authentication over HTTP is disabled by default. This can be reenabled with a configuration setting.