Support Domain Expressions for GlueHiveMetastore #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to have CI run and fix any issues. I'm also curious about any additional suggestions on test cases |
rash67
force-pushed
the
glue-hive-metastore-impl
branch
3 times, most recently
from
e0101fd
to
836557e
Compare
|
ignore the revert of the CI rules; i'm using that while developing so i can actually run CI on my development branches it won't be in the final draft |
|
i'll be removing the revert as I'll just use the CI run that executes in the main presto repo space |
rash67
force-pushed
the
glue-hive-metastore-impl
branch
2 times, most recently
from
8341e2e
to
6dc20d4
Compare
rash67
changed the title
This work adds support that converts expressions on partition columns into valid glue expresions to improve performance. The Domain for each partition column is converted, if possible, into a glue expression per https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-catalog-partitions.html#aws-glue-api-catalog-partitions-GetPartitions The implementation is best-effort and may still return more partitions for the caller to filter out (HivePartitionManager)
rash67
force-pushed
the
glue-hive-metastore-impl
branch
from
6dc20d4
to
3b0b7ec
Compare
electrum
approved these changes
Sep 23, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work adds support that converts expressions on partition columns
into valid glue expresions to improve performance. The Domain for each
partition column is converted, if possible, into a glue expression
per
https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-catalog-partitions.html#aws-glue-api-catalog-partitions-GetPartitions
The implementation is best-effort and may still return more partitions for the caller to filter out (HivePartitionManager)
#611