Fix ALTER TABLE .. RENAME TO .. for MySQL
#586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is covered by existing test: `TestMySqlDistributedQueries#testRenameTable`.
These connectors do not support setting table comments.
findepi
force-pushed
the
findepi/rename-mysql
branch
from
3dd032f
to
4184edb
Compare
|
cc @electrum |
electrum
approved these changes
Apr 4, 2019
kokosing
reviewed
Apr 5, 2019
| @@ -243,6 +244,7 @@ public void renameTable(JdbcIdentity identity, JdbcTableHandle handle, SchemaTab | |||
| { | |||
| // MySQL doesn't support specifying the catalog name in a rename. By setting the | |||
| // catalogName parameter to null, it will be omitted in the ALTER TABLE statement. | |||
| renameTable(identity, null, handle.getSchemaName(), handle.getTableName(), newTableName); | |||
| verify(handle.getSchemaName() == null); | |||
| renameTable(identity, null, handle.getCatalogName(), handle.getTableName(), newTableName); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.