Avoid Marker intermediate representation in DomainCoercer #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps use this method correctly, when it may not be known upfront whether operands have a non-empty intersection. It is a consciously a breaking change, as the method is rarely used (has 0 usages in the project), so accommodating to the change is expected to be easier than maintaining transition period.
raunaqmorarka
approved these changes
Feb 22, 2021
sopel39
approved these changes
Feb 22, 2021
|
thanks for review. |
|
This is because saturated floor/ceil casts are more generic (e.g could be used to reverse cast from date to timestamp). I believe this was discussed once with @martin on slack. |
|
I actually am under impression that floor casts are not more generic. For example, we do not have implementation for these casts from bigint to double, or decimal. While the latter can be added, the former cannot (afaiu). The added advantage of not expressing this with a cast, is that the logic can be dependent on particular values. I am curious to learn more, but indeed a closed PR is not the right place for this discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.