Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queries with very large LIMIT with Redshift #7236

Merged
merged 2 commits into from Mar 10, 2021
Merged

Fix queries with very large LIMIT with Redshift #7236

merged 2 commits into from Mar 10, 2021

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 10, 2021

Redshift does not support LIMIT 2147483648 or more.

Alternative to #7231

@findepi
Fix queries with very large LIMIT with Redshift
6a882b2 
Redshift does not support LIMIT 2147483648 or more.
@findepi
Simplify Phoenix limitFunction
761e6d6 
Now that limit exceeding `Integer.MAX_VALUE` is filtered out in
`JdbcMetadata`, the `PhoenixClient` can be simplified.
@cla-bot cla-bot bot added the cla-signed label Mar 10, 2021
@findepi findepi mentioned this pull request Mar 10, 2021
Closed
hashhar
hashhar approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simpler.

I can't think of a reason why someone would run queries with LIMIT > INT_MAX. Beats the point of using LIMIT in my opinion.

losipiuk
losipiuk approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also nice

@findepi findepi merged commit 3270b55 into trinodb:master Mar 10, 2021
@findepi findepi deleted the findepi/redshift-limit branch March 10, 2021 16:49
@findepi findepi added this to the 354 milestone Mar 10, 2021
@findepi findepi mentioned this pull request Mar 15, 2021
Closed
10 tasks
@findepi findepi mentioned this pull request Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losipiuk losipiuk losipiuk approved these changes

@hashhar hashhar hashhar approved these changes

@kokosing kokosing Awaiting requested review from kokosing

Assignees
No one assigned
Labels
cla-signed
Milestone
354
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@findepi @losipiuk @hashhar