New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Hive connector "hive-hadoop2 to "hive" #8166
Conversation
cc @mosabua |
Wow ... |
@@ -174,13 +174,13 @@ Configuration | |||
------------- | |||
|
|||
Create ``etc/catalog/hive.properties`` with the following contents | |||
to mount the ``hive-hadoop2`` connector as the ``hive`` catalog, | |||
to mount the ``hive`` connector as the ``hive`` catalog, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these really the only instances of the connector name in all the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
from @electrum 's #5625 (review)
are we ok with the breaking change? |
@findepi sorry, I completely forgot about your PR, though I see you closed it. I'm glad you remembered my comment about this breaking people that install libraries. We should call this out, but I'm not concerned, since that's an "unsupported" activity and needs to be handled carefully anyway. |
We could go a different way and add a |
This simplification is long overdue. The original name is kept for compatibility with existing configurations, but a warning is logged when it is used. The plugin directory is also renamed inside the server tarball. We should name the Maven artifact as well, but I'll leave that for a follow up, as it's not obvious what to call it.